Making bsdtar and coreutils fully portable for amd64 #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
executed the following in a loop until I got 0 system dependencies being used: ``` bazel build @bsd_tar_linux_amd64//... && bash -x bazel-bazel-lib/external/bsd_tar_linux_amd64/bsdtar.sh ``` Once that passed I could succesfully run this tool in centos7 amd64 which has a way older glibc
now coreutils are fully portable as well
|
|
|
I see issues #698 and #615 related to this, and I agree the musl approach is more sane as it has less maintenance cost, I wish I opened the issue tracker earlier, on the other hand it took me under 1 hour to get this setup and it helped to unblock my use case. If you don't mind I think it's best to close this ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kind of in between a bug fix and a new feature.
Basically I realized bazel-lib bsdtar and coreutils don't work in centos7 amd64 because of libc version and stuff.
I got the binaries to the point where those are isolated and the entire dependency tree is self-contained,
could do similar work for arm64, but first I wanted to get some feedback
I expect no visible changes to end-users other than more platforms being supported.
For testing I executed all tests in a centos7 docker image and they passed.