WIP: create an interface to allow for convention checking in gazelle #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyler-french
force-pushed
the
convention
branch
9 times, most recently
from
1786849
to
9393b3c
Compare
tyler-french
force-pushed
the
convention
branch
from
9393b3c
to
a352951
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, at Uber, we do not use an index. Instead, we use conventions and a set of
# gazelle:resolvestatements in the root BUILD.bazel file.This is beneficial because it means we can run Gazelle
O(size change)instead of `O(size repo)'This can be enabled by running
bazel run //:gazelle -- --use_conventionswith flagFixes #1907