Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrectly parsed value of gid with horizontal flip flag on #84

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

IoriBranford
Copy link

No description provided.

@baylej
Copy link
Owner

baylej commented Dec 17, 2024

Hi, thank you for this,

What is the issue? I can't infer what it is from the contributed code.

Thanks!

@IoriBranford
Copy link
Author

IoriBranford commented Dec 17, 2024

Gids in TMX files are unsigned int numbers, but atoi is only designed to read numbers in signed int range.
Ints nowadays have pretty much standardized to 32 bits, so a gid with the h-flip flag (the 32nd bit) is outside of signed int range. atoi doesn't handle this well and returns some incorrect value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants