Added internal SDCard reader support

[stemnic]

This kext adds support for the internal SD card reader, tested on my XPS 9570 running 10.15.4

The extra boot arg flag is added as since RTS525A is the model of the xps internal pci sd card reader as per readme in repo

Git repo for kext https://github.com/cholonam/Sinetek-rtsx

[duongleh]

Works great! Thanks for your solution. This issue has been a pain in the ass for a really long time.
Btw, it would be very nice if you update the README file as well as kext.org

[stemnic]

Glad this works for other people aswell. I have added some information in the READMe and kext though i have never written .org files so please edit the stying if its not correct

[tofuliang]

I tested it under OC, it works! But with low performance.
Using a class 10 microSD card, about 4.5MB/s writing and 5.5MB/s reading, while using a external USB3.0 CardReader it can be about 14MB/s writing and 73MB/s reading.

[stemnic]

Yeah preformance is not high, though I prefer that to a none working port. The write speed seems to be an limitation to the kext cholonam/Sinetek-rtsx#3. I would suspect this is due to the "rough" state of the openBSD driver this kext was based on

[bavariancake]

Thanks for the PR @stemnic, and thanks for testing this out @tofuliang! I will test this out in the next few days and merge your PR if everything works on my end.

[bavariancake]

Are you able to format an SD card @stemnic?

I get I/O errors with Disk Utility every time:

dd has similar problems:

$ sudo gdd if=/dev/urandom of=/dev/rdisk2 bs=128k status=progress
gdd: error writing '/dev/rdisk2': Input/output error
1+0 records in
0+0 records out
0 bytes copied, 0.712663 s, 0.0 kB/s

This happens with the latest release from Sinetek-rtsx as well.

Can you reproduce this issue as well, or do other cards work for you?

[eamigo86]

Hi @bavariancake, I was able to format my SD card without problems. I have the latest 2.2 Sinetek-rtsx version.

[bavariancake]

@eamigo86 what about formatting as HFS+ (Mac OS Extended)?

If that fails, what happens when you format ExFAT after trying HFS+?

[eamigo86]

@bavariancake both formats work correctly. Although the I/O speed is quite low as said @duongle26

Note: I'm making the test with a (microSD) memory with SD adapter.

[bavariancake]

I tested a few more cards: Sony 32GB microSD, Sandisk 16GB Ultra, Sandisk 16GB Extreme, Sandisk 64GB Extreme Pro (I guess you need more superlatives when your cheap card is "beyond" in Latin). They all format apparently, except for the 16GB Ultra card, but when I try to write a large file to a formatted filesystem, it eventually fails. All of these cards work as expected via USB card reader, so I suspect the driver has some underlying issues that are exposed intermittently, which is generally a recipe for data loss.

I would like to see the driver get a few more bug fixes / bounds checking / testing / whatever is needed before we recommend it to everybody..

@eamigo86 if you have some time to test this, can you format a card as HFS+ for example, then run the following?

# change 'mysdcard' to your card's volume name
$ dd if=/dev/urandom of=/Volumes/mysdcard/testfile.dat bs=128k status=progress

This should eventually fail with something like "volume out of space", but I get an I/O error well before that happens on several SD cards.

[bavariancake]

Opened an issue on the original project: cholonam/Sinetek-rtsx#10

Maybe we can get some of these issues ironed out, we'll see. Let's wait on merging this until we know more.

[M69W]

RealtekCardReader
https://github.com/0xFireWolf/RealtekCardReader
https://github.com/0xFireWolf/RealtekCardReaderFriend/