-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add clamped Pockels calculation capability #67
base: main
Are you sure you want to change the base?
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Virginie de Mestral.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Virginie de Mestral.
|
Corrected the calculation of the Pockels tensor after pytest Added Pockels test-suite for AlAs Removed unused variables after pytest
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Virginie de Mestral.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is awesome, thanks @vdemestral ! Just some minor changes!
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you accept our Contributor License Agreement before we can merge your contribution. You can accept the CLA by just copying the sentence below and posting it as a Pull Request Comment. I have read the CLA Document and I hereby accept the CLA 2 out of 3 committers have signed the CLA. |
I have read the CLA Document and I hereby accept the CLA |
recheck |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
- Coverage 86.77% 86.45% -0.32%
==========================================
Files 34 34
Lines 2502 2548 +46
==========================================
+ Hits 2171 2203 +32
- Misses 331 345 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I have read the CLA Document and I hereby accept the CLA |
I add the possibility of computing the clamped Pockels tensors into the
VibroMixing
class.