Add support for MP3 #335
Closed
Add support for MP3 #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you mixed up the subtypes and default_subtypes, as mentioned in the comments. If you fix this, I'll gladly merge your pull request. Otherwise, I can also do the changes myself, as you wish. |
|
I think you mean there is no default_subtype for the format 'MPEG', so I add 'MP3' for it in 'default_subtypes'. Please fix it if I was wrong. BTW, my vim automatically removed three space at the end of line in this commit. |
Closed
magicse
reviewed
Sep 25, 2022
| 'ALAC_16': 0x0070, # Apple Lossless Audio Codec (16 bit). | ||
| 'ALAC_20': 0x0071, # Apple Lossless Audio Codec (20 bit). | ||
| 'ALAC_24': 0x0072, # Apple Lossless Audio Codec (24 bit). | ||
| 'ALAC_32': 0x0073, # Apple Lossless Audio Codec (32 bit). | ||
| 'MPEG_LAYER_I': 0x0080, # MPEG-1 Audio Layer I. | ||
| 'MPEG_LAYER_II': 0x0081, # MPEG-1 Audio Layer II. | ||
| 'MP3': 0x0082, # MPEG-2 Audio Layer III. |
There was a problem hiding this comment.
'MPEG_LAYER_III': 0x0082, #MPEG-2 Audio Layer III.
There was a problem hiding this comment.
libsndfile library return "MPEG_LAYER_III" subtype
magicse
approved these changes
Sep 25, 2022
There was a problem hiding this comment.
I tested it with changes and it work well.
Also I made tested pull request to pythorch audio pytorch/audio#2711
| @@ -128,6 +136,7 @@ | |||
| 'OGG': 'VORBIS', | |||
| 'MPC2K': 'PCM_16', | |||
| 'RF64': 'PCM_16', | |||
| 'MPEG': 'MP3', | |||
|
This has already been incorporated in #325 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.