Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of PHP and Debian #907

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

flosoft
Copy link
Contributor

@flosoft flosoft commented Dec 29, 2022

Tested this on my Docker containers, upgrade seems to work without any issues.

@tigeli
Copy link

tigeli commented Jun 19, 2023

Looks good to me, no issues experienced while testing. @bassmaster187 PHP 7.3 has been EOL over 1.5 years already.

@bassmaster187
Copy link
Owner

Is the path still valid for custom php.ini?

- ./docker/webserver/php.ini:/usr/local/etc/php/php.ini

@flosoft
Copy link
Contributor Author

flosoft commented Jul 3, 2023

It is indeed still valid. Just checked.
Screenshot 2023-07-03 at 18-20-38 PHP 8 1 20 - phpinfo()

@flosoft
Copy link
Contributor Author

flosoft commented Sep 5, 2024

This has been open for a while now - any reason for not merging this one?

@tigeli
Copy link

tigeli commented Sep 5, 2024

This has been open for a while now - any reason for not merging this one?

Wondering that as well.. I could create MR for updating mono to 6.12.0.206, MariaDB atleast either 10.5 or 10.6 and grafana at least to 10.4 but not going to if they are never going to get merged.

@superfloh247
Copy link
Contributor

updating the database software without upgrading the database data can lead to loads of (remotely/automatically) hard to solve problems, for example see https://stackoverflow.com/questions/37856155/mysql-upgrade-failed-innodb-tables-doesnt-exist

@bassmaster187
Copy link
Owner

This has been open for a while now - any reason for not merging this one?

The problem was, a restore of a huge database didn't work. Maybe because of php settings that not applied to the new php version. I think it would work, if anybody will check the new settings of php.ini.
Plus, I want to be on par with raspberry installs. So that should be also adjusted.

string phpinipath = "/etc/php/7.0/apache2/php.ini";

Keep in mind, if you update a 3rd party software, a couple of updates will be failed and you have to spend time to fix it. With over 7000 Teslalogger users, that can be a huge problem. So I want to update 3rd party software only if the is a reason to do it like security problems. what was your reason to update?

@tigeli
Copy link

tigeli commented Sep 6, 2024

So I want to update 3rd party software only if the is a reason to do it like security problems. what was your reason to update?

PHP versions before 8.1 are "end of life" and there are several vulnerabilites which haven't been patched for 7.3 which might or might not be relevant for TeslaLogger.

@flosoft
Copy link
Contributor Author

flosoft commented Sep 6, 2024

The main reason for the bump was that I had issues on my ARM64 docker image not working properly and occasionally just showing a blank page. Bumping PHP fixed that.

@LightBridge16
Copy link

does somebody know how I can php8.3 working with docker/teslalogger on the raspberry pi 4?
in the browser I see the php code but not as website it self.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants