Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructured how connectivity tests are configured and run [RIAK-1608]. #750

Merged
merged 2 commits into from
Mar 14, 2015

Conversation

tburghart
Copy link
Contributor

Due to leftover configuration attributes from prior tests within this module (see RIAK-1607 (#747)), the order of tests has to be managed. In order to accomplish this and be able to see exactly what configurations are used for each test, configuration blocks have been more directly associated with each connectivity test.

Due to leftover configuration attributes from prior tests within this module (see RIAK-1607), the order of tests has to be managed.  In order to accomplish this and be able to see exactly what configurations are used for each test, configuration blocks have been more directly associated with each connectivity test.
[ConfRepl, {riak_core, [{ssl_enabled, true}
] ++ CIsite3#ci.ssl }],
true},
{"wildcard certifictes on both ends",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"certificates"

@macintux
Copy link
Contributor

Mostly superficial tweaks suggested. Passes locally, looks very good.

@tburghart
Copy link
Contributor Author

I'll make those tweaks, and do some re-ordering, and may add a couple of ACL-related ones.

Using a heavily-instrumented riak_core_ssl_util, we're not getting coverage of some of the verification clauses.

Reordered tests to use lighter configurations.
Added test for mismatched ACL.
Added timeout override.
tburghart added a commit that referenced this pull request Mar 14, 2015
Restructured how connectivity tests are configured and run [RIAK-1608].
@tburghart tburghart merged commit 77f2a56 into master Mar 14, 2015
@tburghart tburghart deleted the bugfix/reorder-replication2-ssl-tests branch March 14, 2015 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants