-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test group annotations to riak_test #674
Add test group annotations to riak_test #674
Conversation
- Tests can be annotated with one or more '-test_type(name)' attributes. - Tests can be declared to be in multiple groups - These types can be run in groups via the riak_test command line --groups (-g) option - Multiple groups can be specified by comma delimiting.
…ake lists. - For example, in a riak_test: -test_type([bucket_types, http]).
Project = list_to_binary(rt_config:get(rt_project, "undefined")), | ||
compose_test_data(DirTests, SpecificTests, ParsedArgs); | ||
load_tests(RawGroupList, ParsedArgs) -> | ||
Groups = lists:foldl(fun(X, Acc) -> string:tokens(X, ", ") ++ Acc end, [], RawGroupList), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize I did the same thing at L248, but this line goes a bit long. Can we pull out the fold funtion definition or put the fold parameters on separate lines to keep within 80 columns?
Should you be able to include one or more
|
I also wonder if this should not (also) be metadata in GiddyUp. Then someone could write: $ riak_test -c riak_ee -r config -g security |
We could also then potentially filter the matrix to tests in specific groups. |
@seancribbs sounds good -- please let me know if there is anything that would make integration easier or more sensible. |
- Options --groups and --tests are mutually exclusive for now. - fix indentation for overly long lines.
+1 |
Add test group annotations to riak_test
Enable tests to be tagged with a list of attributes that can be called on the riak_test command line to group or aggregate tests (#667)
Test are tagged with the following attribute:
Then, instead of named tests at the command line, groups are specified:
This will result in 2 matches against the above test; any match will run the test: