Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Riak Startup when Strong Consistency is Misconfigured #636

Merged
merged 1 commit into from
Jun 16, 2014

Conversation

jburwell
Copy link
Contributor

Tests the Riak startup behavior when strong consistency is enabled and AAE is disabled as described in basho/riak_kv#959. Riak should startup without error, but the ensembles should never reach quorum.

In addition to adding this test case, the following enhancements were made to the reset-current-env.sh script to properly execute strong consistency tests requiring more than five (5) nodes:

  • Adds additional console output to reset-current-env to explain configuration and steps being executed
  • Adds the -n option to the reset-current-env script to specify the number of nodes to build. By default, 5 will be created.

I had intended to add a test to verify the Riak KV warning PR. Unfortunately, riak_test's log capture facility is not enabled at startup, and requires significant changes to allow such operation. @kelly and I determined that these changes were too invasive given the proximity of the Riak 2.0 release. Therefore, I have opened the following tickets to enhance the framework and add the automated test for the warning to be addressed in the 2.1 release cycle:

  AAE is disabled.  (defect basho/riak_kv#959)
- Adds additional console output to reset-current-env to explain
  configuration and steps being executed
- Adds the -n option to the reset-current-env script to specify the
  number of nodes to build.  By default, 5 will be created.
@kellymclaughlin
Copy link
Contributor

Looks good and test passes.

👍

jburwell added a commit that referenced this pull request Jun 16, 2014
Verify Riak Startup when Strong Consistency is Misconfigured
@jburwell jburwell merged commit 6733c09 into master Jun 16, 2014
@jburwell jburwell deleted the bugfix/jsb/start-ensemble-without-aae branch June 16, 2014 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants