Feature th http client for RTS-258 #1371
Conversation
Queries still require equality on family and series with a range of timestamps, but will now retrieve records with local keys defined after the partition key.
…ldb backend. Depends on same branch in eleveldb
…rrent order in build_object
…ch replies or should we just use standard put replies?
…element local key.
…to feature-jrd-e2e_batches
…eature-jrd-e2e_batches-ff
…ed total batch size
…atches if the total number of records is less than the max per batch
…f it is used at all.
…ive, to ensure it is always greater than the start key.
…t/flexi_keys Conflicts: src/riak_kv_qry_compiler.erl
…re-jrd-e2e_batches-ff
Flexible keys Reviewed-by: andytill
Output some query debug information Reviewed-by: javajolt
* removed malformed_request * changed CB_RV_SPEC to cb_rv_spec(T) type * simplified forbidden/2 * removed check_permissions/2 as it is no longer needed (is_authorized/2 handles that job now) * removed utf8_to_binary/1 as it is no longer used (riak_kv_wm_ts_util has it for those functions who needs it).
… riak_kv_wm_timeseries_listkeys.
* error_out, handle_error and flat_format removed as they are no longer used.
…right order. And all helper functions at the end of the module.
|
@lehoff have a look how keys are sent in standard riak: https://github.com/basho/riak_kv/blob/riak_ts-develop/src/riak_kv_wm_keylist.erl#L230, and how they are received: https://github.com/basho/riak-erlang-http-client/blob/riak_ts-develop/src/rhc_listkeys.erl#L86. There is also my branch in riak-erlang-http-client, https://github.com/basho/riak-erlang-http-client/tree/feature/az/http-client, where I have implemented all the TS-specific API calls. I then used riakhttpc as the alternative client in ts_cluster_comprehensive (basho/riak_test#1016) to run the same scenario as it normally does with the protobuffer client (riakc). The wrappers in riak-erlang-http-client will probably need to be modified per your changes in riak_kv. |
…re-th-http_client-rebase # Conflicts: # src/riak_kv_pb_timeseries.erl # src/riak_kv_ts_api.erl # src/riak_kv_ts_util.erl # src/riak_kv_wm_timeseries.erl # src/riak_kv_wm_timeseries_listkeys.erl # src/riak_kv_wm_timeseries_query.erl # src/riak_kv_wm_ts_util.erl
|
It should be stream - fix for that coming up. |
|
The query callback still needs some tweaks to accept the recently implemented WITH-clause for the CREATE query. The changes are in lehoff-b#2, for you to consider and pull. With those changes, I can confirm the test in basho/riak_test#1016 passes. Edit: The riak_test PR is 1015, not 1016. |
…develop amend create_table code path to take into account WITH-props
|
+1 383e049 The tests (basho/riak_test#1015) all pass. |
Feature th http client for RTS-258 Reviewed-by: hmmr
|
... and the dialyzer says no, with a strange unrelated error to eleveldb. |
|
Okaay, it appears @lehoff forgot to accept lehoff-b#3, something I had presumed he did.. I have opened a yet another PR, with identical contents as this one plus the last commit to fix the dialyzer issue: #1382. |
|
Should be covered by #1398 |
Re-worked to use Webmachine better.
Open issues:
<html>block. Perhaps we should change the design and provide something more useful. It is not of much use when doing a curl or http (httpie.org) request on the command line.