Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize the success response from tsgetresp and tsqueryresp #276

Merged
merged 4 commits into from
Apr 15, 2016
Merged

Standardize the success response from tsgetresp and tsqueryresp #276

merged 4 commits into from
Apr 15, 2016

Conversation

hazen
Copy link

@hazen hazen commented Apr 15, 2016

This is consistent with the tsqueryresp case, too.

deserialize(tsgetresp) ->
{ok, {[], []}};
deserialize({tsgetresp, {_, _, []}}) ->
{[], []};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want all of these to return ok, right? In which case this clause shouldn't be here. @hmmr already has the other change in #277

@hazen hazen changed the title Handle the "not found" case: a single tsgetresp atom Standardize the success response from tsgetresp and tsqueryresp Apr 15, 2016
@lukebakken
Copy link
Contributor

+1 fc6cb24

borshop added a commit that referenced this pull request Apr 15, 2016
Standardize the success response from tsgetresp and tsqueryresp

Reviewed-by: lukebakken
@hazen
Copy link
Author

hazen commented Apr 15, 2016

@borshop merge

@borshop borshop merged commit fc6cb24 into basho:riak_ts-develop Apr 15, 2016
@hazen hazen deleted the bch-fix-tsgetresp branch April 15, 2016 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants