Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embeddings #214

Merged
merged 24 commits into from
Feb 14, 2025
Merged

Embeddings #214

merged 24 commits into from
Feb 14, 2025

Conversation

AnFreTh
Copy link
Collaborator

@AnFreTh AnFreTh commented Feb 12, 2025

This pull request includes significant changes to the testing workflow, attention utilities, embedding layer, base model, and transformer model. The most important changes include adding a new GitHub Actions workflow for unit testing, removing rotary embeddings from the attention utilities, updating the embedding layer to handle additional feature types, and modifying the base and transformer models to support the new embedding layer structure.

Testing Workflow:

  • .github/workflows/pr-tests.yml: Added a GitHub Actions workflow to run unit tests on pull requests targeting the develop and master branches. This includes setting up Python, installing dependencies, and running tests using pytest.

Attention Utilities:

Embedding Layer:

Base Model:

Transformer Model:

Lightning Wrapper:

@AnFreTh AnFreTh closed this Feb 12, 2025
@AnFreTh AnFreTh reopened this Feb 12, 2025
@AnFreTh AnFreTh requested a review from mkumar73 February 12, 2025 13:48
@AnFreTh
Copy link
Collaborator Author

AnFreTh commented Feb 12, 2025

Hey @mkumar73 - I added a workflow integrating a few unit tests as a start. Could you have a closer look? It seems unnecessarily slow.

@AnFreTh AnFreTh merged commit c379a7a into develop Feb 14, 2025
1 check passed
@AnFreTh AnFreTh added this to the v1.2.0 milestone Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant