-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embeddings #214
Merged
Merged
Embeddings #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to include them in feature information
…DefaultMambularConfig #209
Hey @mkumar73 - I added a workflow integrating a few unit tests as a start. Could you have a closer look? It seems unnecessarily slow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the testing workflow, attention utilities, embedding layer, base model, and transformer model. The most important changes include adding a new GitHub Actions workflow for unit testing, removing rotary embeddings from the attention utilities, updating the embedding layer to handle additional feature types, and modifying the base and transformer models to support the new embedding layer structure.
Testing Workflow:
.github/workflows/pr-tests.yml
: Added a GitHub Actions workflow to run unit tests on pull requests targeting thedevelop
andmaster
branches. This includes setting up Python, installing dependencies, and running tests usingpytest
.Attention Utilities:
mambular/arch_utils/layer_utils/attention_utils.py
: Removed therotary
parameter and related code from theAttention
andTransformer
classes, simplifying the attention mechanism. [1] [2] [3] [4] [5]Embedding Layer:
mambular/arch_utils/layer_utils/embedding_layer.py
: Updated theEmbeddingLayer
class to handle an additionalemb_feature_info
parameter and process embedding features. Modified theforward
method to integrate these new features. [1] [2] [3] [4] [5] [6] [7]Base Model:
mambular/base_models/basemodel.py
: Updated theencode
method to accept a singledata
parameter instead of separatenum_features
andcat_features
parameters. [1] [2]Transformer Model:
mambular/base_models/ft_transformer.py
: Modified theFTTransformer
class to accept a tuple of feature information and updated theforward
method to handle the new embedding layer structure. [1] [2] [3]Lightning Wrapper:
mambular/base_models/lightning_wrapper.py
: Adjusted theforward
,training_step
,validation_step
,test_step
, andpredict_step
methods to work with the new embedding layer structure. [1] [2] [3] [4] [5] [6] [7] [8] [9]