-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embeddings #213
Closed
Closed
Embeddings #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to the testing workflow and various model classes to enhance functionality and maintainability. The most important changes involve adding a new GitHub Actions workflow for unit tests, removing the rotary embedding from the attention mechanism, and updating the embedding layer to handle additional embedding features.
Testing Workflow:
.github/workflows/pr-tests.yml
: Added a new GitHub Actions workflow to run unit tests on pull requests targeting thedevelop
andmaster
branches. This workflow sets up Python, installs dependencies, runs tests usingpytest
, and enforces test success before allowing merges.Model Class Updates:
mambular/arch_utils/layer_utils/attention_utils.py
: Removed therotary
parameter and associated logic from theAttention
andTransformer
classes, simplifying the attention mechanism. [1] [2] [3] [4] [5]Embedding Layer Enhancements:
mambular/arch_utils/layer_utils/embedding_layer.py
: Enhanced theEmbeddingLayer
class to handle an additionalemb_feature_info
parameter and updated the forward method to process these embedding features. [1] [2] [3] [4] [5] [6] [7]Base Model Adjustments:
mambular/base_models/basemodel.py
: Modified theencode
method to accept a singledata
parameter instead of separatenum_features
andcat_features
parameters. [1] [2]FTTransformer and Lightning Wrapper Updates:
mambular/base_models/ft_transformer.py
: Updated theFTTransformer
class to accept a tuple of feature information and adjusted the forward method accordingly. [1] [2] [3]mambular/base_models/lightning_wrapper.py
: Refactored theLightningWrapper
class to handle the new feature information tuple and updated various methods to align with this change. [1] [2] [3] [4] [5] [6] [7] [8] [9]