fix #3098 【5.1】エディタテンプレート新規登録・編集で必須項目を記入せず、アイコン画像を入れ保存するとエラーが発生する【エディタテンプレート】 #3114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…エラーが発生する【エディタテンプレート】
ryuring
requested changes
Feb 15, 2024
| @@ -865,18 +865,18 @@ public function file($fieldName, $options = []): string | |||
|
|
|||
| // PHP5.3対応のため、is_string($value) 判別を実行 | |||
| $delCheckTag = ''; | |||
| if ($fileLinkTag && $linkOptions['delCheck'] && (is_string($value) || empty($value['session_key']))) { | |||
| if ($fileLinkTag && $linkOptions['delCheck'] && (is_string($value) || (is_object($value) && $value->getError() == UPLOAD_ERR_NO_FILE))) { | |||
There was a problem hiding this comment.
@HungDV2022 empty($value['session_key']) は削除しないようにしてください、ファイルの一時保存機能が正常動作しなくなるためです
There was a problem hiding this comment.
@ryuring empty($value['session_key'])を追加しました。確認お願いします。
|
@HungDV2022 ありがとうございました。マージします。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.