Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ユニットテスト BlogPostsTable::beforeSave #3087

Merged
merged 10 commits into from
Feb 21, 2024
Merged

ユニットテスト BlogPostsTable::beforeSave #3087

merged 10 commits into from
Feb 21, 2024

Conversation

thangnnmd
Copy link
Collaborator

No description provided.

@HungDV2022
Copy link
Collaborator

@thangnnmd コードを再フォーマットして下さい。 // format lại code đi a

@HungDV2022 HungDV2022 assigned thangnnmd and unassigned HungDV2022 Feb 13, 2024
@ryuring ryuring added this to the 5.0.9 milestone Feb 15, 2024
@thangnnmd
Copy link
Collaborator Author

@HungDV2022 fromat code and add some comment

@HungDV2022 HungDV2022 assigned ryuring and unassigned thangnnmd Feb 16, 2024
@HungDV2022
Copy link
Collaborator

@ryuring レピューをお願いします。

@ryuring
Copy link
Collaborator

ryuring commented Feb 17, 2024

@thangnnmd @HungDV2022
次のコードについて true のテストをしなければ意味がないと思います。

$this->BlogPostsTable->isExcluded();

@ryuring ryuring assigned HungDV2022 and thangnnmd and unassigned ryuring Feb 17, 2024
@ryuring ryuring added the Reviewed レビュー済 label Feb 17, 2024
@thangnnmd
Copy link
Collaborator Author

thangnnmd commented Feb 17, 2024 via email

@thangnnmd
Copy link
Collaborator Author

@HungDV2022 $this->BlogPostsTable->isExcluded();
make it meaningful.

@HungDV2022
Copy link
Collaborator

@ryuring レピューをお願いします。

@HungDV2022 HungDV2022 assigned ryuring and unassigned HungDV2022 and thangnnmd Feb 19, 2024
@ryuring
Copy link
Collaborator

ryuring commented Feb 19, 2024

@HungDV2022 @thangnnmd シナリオを使ってもう少しコードを短くできないでしょうか?

@ryuring ryuring assigned HungDV2022 and thangnnmd and unassigned ryuring Feb 19, 2024
@thangnnmd thangnnmd removed their assignment Feb 20, 2024
@thangnnmd
Copy link
Collaborator Author

@HungDV2022 add BlogPostsScenario.class, please see it

@HungDV2022
Copy link
Collaborator

@HungDV2022 add BlogPostsScenario.class, please see it

@thangnnmd 新しいシナリオを作成ではなく既存シナリオを使った方がいいと思います。//a dùng cái Scenario cũ nhá, thiếu phần nào bổ sung = Factory ý.

@HungDV2022 HungDV2022 assigned thangnnmd and unassigned HungDV2022 Feb 20, 2024
@thangnnmd thangnnmd assigned HungDV2022 and unassigned thangnnmd Feb 20, 2024
@thangnnmd
Copy link
Collaborator Author

@HungDV2022 Is this solution better?

@thangnnmd
Copy link
Collaborator Author

#3087 ユニットテスト調整

@HungDV2022
Copy link
Collaborator

@ryuring コードが大分減らしました。確認お願いします。

@HungDV2022 HungDV2022 assigned ryuring and unassigned HungDV2022 Feb 21, 2024
@ryuring
Copy link
Collaborator

ryuring commented Feb 21, 2024

@thangnnmd @HungDV2022 だいぶスッキリしましたね。ありがとうございます。

@ryuring ryuring merged commit 0fa83e4 into baserproject:dev-5.1 Feb 21, 2024
1 check passed
@ryuring ryuring modified the milestones: 5.0.9, 5.0.10 Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed レビュー済
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants