Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ユニットテスト調整 BlogCommentsService::getBlogContent #3086

Merged
merged 5 commits into from
Feb 19, 2024
Merged

ユニットテスト調整 BlogCommentsService::getBlogContent #3086

merged 5 commits into from
Feb 19, 2024

Conversation

thangnnmd
Copy link
Collaborator

No description provided.

@HungDV2022 HungDV2022 assigned thangnnmd and unassigned HungDV2022 Feb 6, 2024
@ryuring ryuring added this to the 5.0.9 milestone Feb 15, 2024
@thangnnmd
Copy link
Collaborator Author

@HungDV2022 format code and some comment

@HungDV2022
Copy link
Collaborator

@ryuring レピューをお願いします。

@HungDV2022 HungDV2022 assigned ryuring and unassigned thangnnmd Feb 16, 2024
@ryuring
Copy link
Collaborator

ryuring commented Feb 17, 2024

@thangnnmd @HungDV2022 ブログコンテンツが存在しない場合のテストを追加してください

@ryuring ryuring assigned HungDV2022 and thangnnmd and unassigned ryuring Feb 17, 2024
@ryuring ryuring added the Reviewed レビュー済 label Feb 17, 2024
@thangnnmd
Copy link
Collaborator Author

thangnnmd commented Feb 17, 2024 via email

@thangnnmd
Copy link
Collaborator Author

@HungDV2022 add case check content no exist

@HungDV2022
Copy link
Collaborator

コンテンツ

@ryuring ユニットテストを追加しました。確認お願いします。

@HungDV2022 HungDV2022 assigned HungDV2022 and ryuring and unassigned HungDV2022 and thangnnmd Feb 19, 2024
@ryuring ryuring merged commit 663bf1a into baserproject:dev-5.1 Feb 19, 2024
1 check passed
@ryuring
Copy link
Collaborator

ryuring commented Feb 19, 2024

@thangnnmd @HungDV2022 ありがとうございます。マージしました。

@ryuring ryuring removed this from the 5.0.9 milestone Feb 25, 2024
@ryuring ryuring added this to the 5.0.10 milestone Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed レビュー済
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants