testGetBlogTemplates #3067
Closed
testGetBlogTemplates #3067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryuring
requested changes
Jan 29, 2024
| $this->Blog->BcBaser->siteConfig['theme'] = $theme; | ||
| $result = $this->Blog->getBlogTemplates(); | ||
| $this->assertEquals($result, $expected, 'ブログテンプレートを正しく取得できません'); | ||
| $result = $this->Blog->getBlogTemplates(1); |
There was a problem hiding this comment.
@nghiem-mb getBlogTempletes の第一引き数 $siteId の初期値は、1に変更してください。
baserCMS4から、baserCMS５になるにあたり、site_id が 0 というのはなくなったためです。
| $this->assertEquals($result, $expected, 'ブログテンプレートを正しく取得できません'); | ||
| $result = $this->Blog->getBlogTemplates(1); | ||
| $this->assertEquals($expected, $result); | ||
| $this->expectException('Cake\Datasource\Exception\RecordNotFoundException'); |
There was a problem hiding this comment.
@nghiem-mb ヘルパー呼び出しの際に、RecordNotFoundException が出てしまうのは良くないので、どこかで例外処理を書く必要があります。
| } | ||
|
|
||
| public static function getBlogTemplatesDataProvider() | ||
| { | ||
| return [ | ||
| ['nada-icons', ['default' => 'default']] | ||
| ['nada-icons', ['Blog' => 'Blog','default' => 'default']] |
There was a problem hiding this comment.
@nghiem-mb 結果に、'Blog' => 'Blog' が入ってしまってはいけません。何が原因か調査してもらってもいいですか？
|
#3113 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.