fix #4105 【お気に入り】お気に入り一覧に別のユーザーのデータまで表示される問題を解決

plugins/bc-favorite/src/Service/FavoritesService.php

@@ -12,6 +12,7 @@
 namespace BcFavorite\Service;
 
 use BcFavorite\Model\Table\FavoritesTable;
+use BaserCore\Utility\BcUtil;
 use Cake\Datasource\EntityInterface;
 use Cake\ORM\Exception\PersistenceFailedException;
 use Cake\ORM\Query;
@@ -70,7 +71,12 @@ public function getIndex(array $queryParams): Query
         if (!empty($queryParams['num'])) {
             $options = ['limit' => $queryParams['num']];
         }
-        $query = $this->Favorites->find('all', $options)->order(['sort']);
+        $query = $this->Favorites->find('all', $options)
+        ->where(
+            ['Favorites.user_id' => BcUtil::loginUser()->id]
+        )
+        ->order(['sort']);
+
         return $query;
     }
 

plugins/bc-favorite/tests/TestCase/Service/FavoritesServiceTest.php

@@ -90,6 +90,8 @@ public function testGet(): void
      */
     public function testGetIndex(): void
     {
+        $this->loadFixtureScenario(InitAppScenario::class);
+        $this->loginAdmin($this->getRequest());
         $this->loadFixtureScenario(FavoritesScenario::class);
         $result = $this->FavoritesService->getIndex(['num' => 2]);
         $this->assertEquals(2, $result->all()->count());
@@ -144,6 +146,8 @@ public function testUpdate(): void
     public function testDelete()
     {
         $this->loadFixtureScenario(FavoritesScenario::class);
+        $this->loadFixtureScenario(InitAppScenario::class);
+        $this->loginAdmin($this->getRequest());
         $this->FavoritesService->delete(1);
         $users = $this->FavoritesService->getIndex([]);
         $this->assertEquals(5, $users->all()->count());