Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: additional error handling safety to install.sh script #278

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: additional error handling safety to install.sh script #278

wants to merge 1 commit into from

Conversation

bradburm
Copy link

This update enhances the robustness of the installation script by replacing set -e with set -euo pipefail. This change ensures:

  • The script exits immediately if a command fails (-e),
  • Any attempt to use an unset variable is treated as an error (-u),
  • Errors in any part of a pipeline are detected and handled properly (pipefail).
  • This adjustment provides stronger safeguards and prevents potential issues during system configuration.

Appreciate there are no pipelines in this script, but taking the chance to add it now as there could be in future.

Please review and let me know if any further adjustments are needed. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bradburm