Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the LazyVIM extras more modular based on the installed dev language #269

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tonysm
Copy link
Contributor

@tonysm tonysm commented Sep 9, 2024

Changelog

  • Removes the base lazyvim.json
  • Enable the LazyVIM extras plugin when the language is installed

I started this work at #156 but it was mixed with changing PHP's default LSP on LazyVIM. I'll send a separate PR for that.

@tonysm tonysm mentioned this pull request Sep 9, 2024
;;
PHP)
sudo add-apt-repository -y ppa:ondrej/php
sudo apt -y install php8.3 php8.3-{curl,apcu,intl,mbstring,opcache,pgsql,mysql,sqlite3,redis,xml,zip}
php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');"
php composer-setup.php --quiet && sudo mv composer.phar /usr/local/bin/composer
rm composer-setup.php

enable_lazyvim_extras "lazyvim.plugins.extras.lang.php" "lazyvim.plugins.extras.lang.typescript"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure the typescript should be included here ? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it because I usually write JavaScript too in my PHP apps

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but then the node js option would take care of this, right ?

Copy link
Contributor Author

@tonysm tonysm Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might, but these days I'm not using Node for NPM and stuff, I'm using Importmaps but still writing JavaScript

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants