-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the LazyVIM extras more modular based on the installed dev language #269
base: master
Are you sure you want to change the base?
Conversation
c94820f
to
46859d8
Compare
;; | ||
PHP) | ||
sudo add-apt-repository -y ppa:ondrej/php | ||
sudo apt -y install php8.3 php8.3-{curl,apcu,intl,mbstring,opcache,pgsql,mysql,sqlite3,redis,xml,zip} | ||
php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');" | ||
php composer-setup.php --quiet && sudo mv composer.phar /usr/local/bin/composer | ||
rm composer-setup.php | ||
|
||
enable_lazyvim_extras "lazyvim.plugins.extras.lang.php" "lazyvim.plugins.extras.lang.typescript" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure the typescript should be included here ? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it because I usually write JavaScript too in my PHP apps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but then the node js option would take care of this, right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might, but these days I'm not using Node for NPM and stuff, I'm using Importmaps but still writing JavaScript
Changelog
lazyvim.json
I started this work at #156 but it was mixed with changing PHP's default LSP on LazyVIM. I'll send a separate PR for that.