Aws secrets manager simple strings and error checking #1292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String-based secrets
SecretString
can technically be a regular string value and not a JSON object, this PR adds support to fallback to the simple string value when JSON parsing fails.https://docs.aws.amazon.com/secretsmanager/latest/apireference/API_SecretValueEntry.html
You still fetch the value out the same way as a JSON-based secret but from there you can process however you need.
Errors
I also noticed that errors are not returned with a return code from the CLI but within the
Errors
array. Before this PR it just returns an empty secret value for an unknown secret, this PR checks theErrors
array and prints out a message(from AWS) for each error.Current output:
Updated output:
https://docs.aws.amazon.com/cli/latest/reference/secretsmanager/batch-get-secret-value.html (Output -> Errors)