-
Notifications
You must be signed in to change notification settings - Fork 130
chore: improve multisig builder transaction simulation building #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
mdehoog
reviewed
May 13, 2025
mdehoog
reviewed
May 13, 2025
mdehoog
reviewed
May 13, 2025
mdehoog
reviewed
May 13, 2025
xenoliss
reviewed
May 14, 2025
mdehoog
approved these changes
May 14, 2025
@@ -79,14 +79,20 @@ contract DoubleNestedMultisigBuilderTest is Test, DoubleNestedMultisigBuilder { | |||
|
|||
function test_sign_double_nested_safe1() external { | |||
vm.recordLogs(); | |||
sign(safe1, safe3); | |||
bytes memory txData = abi.encodeCall(DoubleNestedMultisigBuilder.sign, (safe1, safe3)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A potentially nicer syntax would be DoubleNestedMultisigBuilder(address(this)).sign(safe1, safe3);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, our transaction simulation for MultisigBuilder setups required a workaround. To simulate a series of transactions through a hierarchy of multisigs using a single multicall, we had to temporarily change the ownership of the very first multisig in the chain to be solely the multicall contract. This allowed the multicall contract to initiate the first approval, which then cascaded up the chain, with each child multisig approving its parent, until the final multisig executed the actual task call(s). While this worked for most simulations, it prevented us from directly testing changes to the real signers of a multisig because our workaround had removed them. This update removes that ownership change. Instead, it directly grants an approval in the initial multisig on behalf of
msg.sender
, achieving the same simulation capability without losing the ability to manipulate actual signers.