Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explicitly initialize loop variable i #133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

qoog
Copy link

@qoog qoog commented Mar 9, 2025

I fixed an issue where the loop variable i was not explicitly initialized in the for loop. In Solidity, an uninitialized variable defaults to 0, which can lead to unexpected behavior and confusion for developers. Explicitly initializing i to 0 ensures better readability and avoids potential misunderstandings in the future.

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants