Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added 3dns to base ecosystem #1602

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

added 3dns to base ecosystem #1602

wants to merge 3 commits into from

Conversation

moiz-3dns
Copy link

What changed? Why?
Added 3DNS to base ecosystem.json file

Notes to reviewers
n/a

How has it been tested?
Confirmed that word limits were respected and PNG image guidelines were adhered to.

@vercel Vercel
Copy link

vercel bot commented Jan 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 10:35pm

@vercel Vercel
Copy link

vercel bot commented Jan 24, 2025

Someone is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 24, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 2/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@moiz-3dns moiz-3dns marked this pull request as ready for review January 24, 2025 20:09
wbnns
wbnns approved these changes Jan 25, 2025
View reviewed changes
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moiz-3dns Thanks for building on Base 🔵

@wbnns wbnns enabled auto-merge (squash) January 25, 2025 15:51
@wbnns wbnns added base ecosystem review This is ecosystem related ready for merge Ready for merge, an additional reviewer is needed labels Jan 25, 2025
@cb-heimdall
Copy link
Collaborator

Review Error for ericbrown99 @ 2025-01-27 14:00:28 UTC
User failed mfa authentication, see go/mfa-help

auto-merge was automatically disabled January 29, 2025 22:30

Head branch was pushed to by a user without write access

@moiz-3dns
Copy link
Author

Resolved conflicts w/ master.
@wbnns @ericbrown99 thanks for your approval. Not sure if it needs another round of approvals since I just commmitted and pushed the conflict fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericbrown99 ericbrown99 ericbrown99 approved these changes

@wbnns wbnns wbnns approved these changes

Assignees
No one assigned
Labels
base ecosystem review This is ecosystem related ready for merge Ready for merge, an additional reviewer is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moiz-3dns @cb-heimdall @wbnns @ericbrown99