Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20lab project submission (Attempt #3) #1561

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

AdamK222
Copy link

What changed? Why?
Submitting once again
Notes to reviewers
To check Base connection you need to connect your wallet first. To do this, you click on the "Connect Wallet" button and approve the connection. Then button shows up that allows to immediately switch your blockchain to Base if your wallet is by default connected to another chain.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 14, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@wbnns
Copy link
Member

wbnns commented Jan 15, 2025

Heya @AdamK222 , thanks for opening a new PR. Left one nit in-line but otherwise this should be good to go if you can update and fix the merge conflict. 🙏

@wbnns wbnns added change(s) requested One or more changes have been requested base ecosystem review This is ecosystem related labels Jan 15, 2025
Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 9:47am

Copy link

vercel bot commented Jan 15, 2025

@AdamK222 is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@AdamK222
Copy link
Author

Hi, changed the description and resolved conflict, let me know if it's alright now

@AdamK222
Copy link
Author

I wanted to follow up. Is everything ok now with the pull request?

Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdamK222 Thanks for building on Base 🔵

@wbnns wbnns removed the change(s) requested One or more changes have been requested label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base ecosystem review This is ecosystem related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants