Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Valora #1515

Closed
wants to merge 1 commit into from
Closed

Add Valora #1515

wants to merge 1 commit into from

Conversation

silasbw
Copy link

@silasbw silasbw commented Dec 30, 2024

No description provided.

@vercel Vercel
Copy link

vercel bot commented Dec 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 7:34pm

@vercel Vercel
Copy link

vercel bot commented Dec 30, 2024

@silasbw is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Dec 30, 2024 •
edited
Loading

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@silasbw silasbw mentioned this pull request Dec 30, 2024
Closed
@wbnns wbnns added the base ecosystem review This is ecosystem related label Jan 9, 2025
@wbnns
Copy link
Member

wbnns commented Jan 9, 2025

@silasbw

Thanks for opening this PR! Confirming this is in our backlog, pending to be reviewed.

wbnns
wbnns approved these changes Jan 25, 2025
View reviewed changes
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silasbw Thanks for building on Base 🔵

@wbnns wbnns added the ready for merge Ready for merge, an additional reviewer is needed label Jan 25, 2025
@wbnns wbnns enabled auto-merge (squash) January 27, 2025 15:15
auto-merge was automatically disabled January 27, 2025 17:04

Head branch was pushed to by a user without write access

@silasbw silasbw force-pushed the valora0 branch 2 times, most recently from 104938e to 02035cd Compare January 29, 2025 17:20
@silasbw
Copy link
Author

silasbw commented Jan 30, 2025

Dumb question @wbnns or @ericbrown99 -- what's left to get this merged 😅 ?

@wbnns
Copy link
Member

wbnns commented Feb 5, 2025

@silasbw Thanks for the patience! Apologies, a backlog of PRs that are conflicting with each other is leading to this delay; I'm bringing this in #1702.

@wbnns wbnns closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericbrown99 ericbrown99 ericbrown99 approved these changes

@wbnns wbnns wbnns approved these changes

Assignees
No one assigned
Labels
base ecosystem review This is ecosystem related ready for merge Ready for merge, an additional reviewer is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@silasbw @cb-heimdall @wbnns @ericbrown99