Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs for getProof, transactionSerializer, and getArgsFromTransactionDepositedOpaqueData. #173

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

alexdwagner
Copy link
Contributor

Still learning this codebase so let me know if any changes are needed :)

Copy link

vercel bot commented Dec 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
op-viem-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2024 11:55pm

Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexdwagner

Thanks Alex! Looks like the linter is picking up a few formatting differences. Can you please update?

@wbnns wbnns added the state: backlog This is pending further review label Dec 17, 2023
@alexdwagner
Copy link
Contributor Author

@alexdwagner

Thanks Alex! Looks like the linter is picking up a few formatting differences. Can you please update?

yes of course! will do

@zencephalon
Copy link
Collaborator

Hey @alexdwagner ! Thanks for starting this. Could U format these docs to follow the same format as the rest of the docs on the site? U can also remove the extra sections at the end of each doc. I think many of the examples won't work as written, particularly because the imports seem off, since people often refer to doc examples to start writing code this feels important to get right. U can refer to .test files as a way to help construct examples.

@alexdwagner
Copy link
Contributor Author

alexdwagner commented Jan 3, 2024 via email

@alexdwagner
Copy link
Contributor Author

Ok, y'all. Pushed changes based on your comments here.

@zencephalon zencephalon merged commit 2143b7c into base-org:main Feb 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: backlog This is pending further review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants