Skip to content

Commit

Permalink
omit value from l1 actions
Browse files Browse the repository at this point in the history
  • Loading branch information
lukasrosario committed Nov 6, 2023
1 parent 9c94c76 commit 9682c84
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 23 deletions.
17 changes: 10 additions & 7 deletions src/actions/public/L1/simulateDepositETH.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,16 @@ export type SimulateDepositETHParameters<
_chainId = TChain extends Chain ? TChain['id'] : number,
> =
& { args: DepositETHParameters; portal: RawOrContractAddress<_chainId> }
& L1SimulateActionBaseType<
typeof ABI,
typeof FUNCTION,
ContractFunctionArgs<typeof ABI, 'payable', typeof FUNCTION>,
TChain,
TChainOverride,
TAccountOverride
& Omit<
L1SimulateActionBaseType<
typeof ABI,
typeof FUNCTION,
ContractFunctionArgs<typeof ABI, 'payable', typeof FUNCTION>,
TChain,
TChainOverride,
TAccountOverride
>,
'value'
>

export type SimulateDepositETHReturnType<
Expand Down
17 changes: 10 additions & 7 deletions src/actions/wallet/L1/writeDepositETH.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,16 @@ export type WriteDepositETHParameters<
_chainId = TChain extends Chain ? TChain['id'] : number,
> =
& { args: DepositETHParameters; portal: RawOrContractAddress<_chainId> }
& L1WriteActionBaseType<
typeof ABI,
typeof FUNCTION,
ContractFunctionArgs<typeof ABI, 'payable', typeof FUNCTION>,
TChain,
TAccount,
TChainOverride
& Omit<
L1WriteActionBaseType<
typeof ABI,
typeof FUNCTION,
ContractFunctionArgs<typeof ABI, 'payable', typeof FUNCTION>,
TChain,
TAccount,
TChainOverride
>,
'value'
>

/**
Expand Down
20 changes: 11 additions & 9 deletions src/actions/wallet/L1/writeDepositTransaction.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,18 @@ export type WriteDepositTransactionParameters<
TChain extends Chain | undefined = Chain,
TAccount extends Account | undefined = Account | undefined,
TChainOverride extends Chain | undefined = Chain | undefined,
> // _chainId = TChain extends Chain ? TChain['id'] : number,
=
> =
& { args: DepositTransactionParameters; portal: RawOrContractAddress<number> }
& L1WriteActionBaseType<
typeof ABI,
typeof FUNCTION,
ContractFunctionArgs<typeof ABI, 'payable', typeof FUNCTION>,
TChain,
TAccount,
TChainOverride
& Omit<
L1WriteActionBaseType<
typeof ABI,
typeof FUNCTION,
ContractFunctionArgs<typeof ABI, 'payable', typeof FUNCTION>,
TChain,
TAccount,
TChainOverride
>,
'value'
>

/**
Expand Down

0 comments on commit 9682c84

Please sign in to comment.