Fix OutputOracle.getL2OutputIndexAfter #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdehoog
force-pushed
the
michael/fix-getL2OutputIndexAfter
branch
from
8fa1424 to
9a9e5c4
Compare
mdehoog
force-pushed
the
michael/fix-getL2OutputIndexAfter
branch
from
9a9e5c4 to
6999087
Compare
chunter-cb
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OutputOracle.getL2OutputIndexAfteris broken, because we weren't adding the offset to the returnedlovalue. Fix (and simplify in the process).Audit finding: https://cantina.xyz/code/a944b747-e288-4c00-91ec-8b05021d034f/findings/13