Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof aggregation improvements #14

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Proof aggregation improvements #14

merged 4 commits into from
Nov 6, 2024

Conversation

mdehoog
Copy link
Collaborator

@mdehoog mdehoog commented Nov 6, 2024

This PR implements two improvements:

  • only generate 1000 proofs before attempting aggregation. If we're far behind, this ensures we test aggregation occasionally, rather than failing on a huge amount of proofs at once
  • only clear the pending if the enclave returns a non-recoverable error (like invalid signer), otherwise we lose a whole bunch of valid proofs

@mdehoog mdehoog force-pushed the michael/fix-aggregation branch from fcf66fd to a4cf887 Compare November 6, 2024 19:49
@mdehoog mdehoog merged commit e9427f7 into main Nov 6, 2024
3 checks passed
@mdehoog mdehoog deleted the michael/fix-aggregation branch November 6, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants