Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added game entry for diablo 4 #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

trapgar
Copy link

@trapgar trapgar commented Jul 4, 2023

Description

Fixes #

How has this veen tested?

Checklist:

  • I have added myself to contributor list in src/manifest.json (nick or/and full name)
  • I have added myself to contributor list in LICENSE file (nick or/and full name)
  • Unit tests pass locally with my changes

New Unit Tests

  • I have added/modified unit tests to cover my change
  • I think there is no sens to test my change (apply on consts modification etc.)
  • I need some help to accomplish

@athieriot
Copy link

Any chance for this to be merged at some point ?

@trapgar
Copy link
Author

trapgar commented Sep 22, 2023

Unlikely - last commit was Nov 8, 2021. At the very least you can edit your local files based on my commit. It's only 1 file so not hard. File location is C:\Users\<USER>\AppData\Local\GOG.com\Galaxy\plugins\installed\battlenet_<UUID>\definitions.py.

@athieriot
Copy link

Yeah I ended up doing that in the end.

It's so sad to see GoG integrations going to rot :(

@whispertante
Copy link

whispertante commented Nov 4, 2023

Anyone knows how to make the "Play" button actually start D4?
BlizzardGame('fenris', 'Diablo IV', 'D4')

"D4" is not working here, "Fen" or "Fenris" neither. The commit is only adding the game.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants