Skip to content

Commit

Permalink
chore: make requested changes
Browse files Browse the repository at this point in the history
- Added changelog entry.
- Removed unnecessary braces around interpolated variable.
- Made property type assignment one line.
  • Loading branch information
jpickwell committed Sep 11, 2020
1 parent 7a28b3e commit 4332644
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ All notable changes to this project will be documented in this file.
### Added
- Fix phpdoc generate for custom cast with parameter [\#986 / artelkr](https://github.com/barryvdh/laravel-ide-helper/pull/986)
- Created a possibility to add custom relation type [\#987 / efinder2](https://github.com/barryvdh/laravel-ide-helper/pull/987)
- Add model property types to magic where methods [\#989 / jpickwell](https://github.com/barryvdh/laravel-ide-helper/pull/989)
- Added `@see` with macro/mixin definition location to PhpDoc [\#1054 / riesjart](https://github.com/barryvdh/laravel-ide-helper/pull/1054)

### Changed
Expand Down
5 changes: 2 additions & 3 deletions src/Console/ModelsCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@ protected function getPropertiesFromTable($model)
[
empty($truePropertyType)
? '$value'
: "{$truePropertyType} \$value",
: "$truePropertyType \$value",
]
);
}
Expand Down Expand Up @@ -725,8 +725,7 @@ protected function setProperty($name, $type = null, $read = null, $write = null,
$this->properties[$name]['comment'] = (string) $comment;
}
if ($type !== null) {
$this->properties[$name]['type'] =
$this->getTruePropertyType($type, $nullable);
$this->properties[$name]['type'] = $this->getTruePropertyType($type, $nullable);
}
if ($read !== null) {
$this->properties[$name]['read'] = $read;
Expand Down

0 comments on commit 4332644

Please sign in to comment.