Parse template tag for generics #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, but tests seem to be failing. Any ideas? |
|
@barryvdh there was an issue with PHP 7. Fixed. |
|
@barryvdh sorry for the varius commits. I only have 7.3 installed on my pc, so I don't get 7.2 issues instantly |
|
Thanks! |
|
Does this also fixes things like Same problem as generics, but for phpdoc types. |
|
@ayrtonandino no, this only fixes templates used in phpdoc method. This is also not fixing templates used in class phpdoc, I'll make a another PR for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes barryvdh/laravel-ide-helper#1442