setIncrBy和setDecrBy更新

baomidou · Aug 8, 2024 · cd42c65 · cd42c65
1 parent 90fa3a4
commit cd42c65
Show file tree

Hide file tree

Showing 6 changed files with 76 additions and 133 deletions.
diff --git a/...re/src/main/java/com/baomidou/mybatisplus/core/conditions/update/LambdaUpdateWrapper.java b/...re/src/main/java/com/baomidou/mybatisplus/core/conditions/update/LambdaUpdateWrapper.java
@@ -94,17 +94,15 @@ public LambdaUpdateWrapper<T> setSql(boolean condition, String setSql, Object...
     public LambdaUpdateWrapper<T> setIncrBy(boolean condition, SFunction<T, ?> column, Number val) {
         return maybeDo(condition, () -> {
             String realColumn = columnToString(column);
-            sqlSet.add(realColumn + Constants.EQUALS + realColumn + Constants.SPACE + Constants.PLUS + Constants.SPACE +
-                (val instanceof BigDecimal ? ((BigDecimal) val).toPlainString() : val));
+            sqlSet.add(String.format("%s=%s + %s", realColumn, realColumn, val instanceof BigDecimal ? ((BigDecimal) val).toPlainString() : val));
         });
     }
 
     @Override
     public LambdaUpdateWrapper<T> setDecrBy(boolean condition, SFunction<T, ?> column, Number val) {
         return maybeDo(condition, () -> {
             String realColumn = columnToString(column);
-            sqlSet.add(realColumn + Constants.EQUALS + realColumn + Constants.SPACE + Constants.DASH + Constants.SPACE +
-                (val instanceof BigDecimal ? ((BigDecimal) val).toPlainString() : val));
+            sqlSet.add(String.format("%s=%s - %s", realColumn, realColumn, val instanceof BigDecimal ? ((BigDecimal) val).toPlainString() : val));
         });
     }
 

diff --git a/mybatis-plus-core/src/main/java/com/baomidou/mybatisplus/core/conditions/update/Update.java b/mybatis-plus-core/src/main/java/com/baomidou/mybatisplus/core/conditions/update/Update.java
@@ -120,7 +120,7 @@ default Children setIncrBy(R column, Number val) {
      * @param val    变量值 1 字段自减 - 1
      */
     default Children setDecrBy(R column, Number val) {
-        return setIncrBy(true, column, val);
+        return setDecrBy(true, column, val);
     }
 
     /**

diff --git a/...lus-core/src/main/java/com/baomidou/mybatisplus/core/conditions/update/UpdateWrapper.java b/...lus-core/src/main/java/com/baomidou/mybatisplus/core/conditions/update/UpdateWrapper.java
@@ -117,16 +117,14 @@ public UpdateWrapper<T> setSql(boolean condition, String setSql, Object... param
     @Override
     public UpdateWrapper<T> setIncrBy(boolean condition, String column, Number val) {
         return maybeDo(condition, () -> {
-            sqlSet.add(column + Constants.EQUALS + column + Constants.SPACE + Constants.PLUS + Constants.SPACE +
-                (val instanceof BigDecimal ? ((BigDecimal) val).toPlainString() : val));
+            sqlSet.add(String.format("%s=%s + %s", column, column, val instanceof BigDecimal ? ((BigDecimal) val).toPlainString() : val));
         });
     }
 
     @Override
     public UpdateWrapper<T> setDecrBy(boolean condition, String column, Number val) {
         return maybeDo(condition, () -> {
-            sqlSet.add(column + Constants.EQUALS + column + Constants.SPACE + Constants.DASH + Constants.SPACE +
-                (val instanceof BigDecimal ? ((BigDecimal) val).toPlainString() : val));
+            sqlSet.add(String.format("%s=%s - %s", column, column, val instanceof BigDecimal ? ((BigDecimal) val).toPlainString() : val));
         });
     }
 

diff --git a/...-core/src/test/java/com/baomidou/mybatisplus/core/conditions/LambdaUpdateWrapperTest.java b/...-core/src/test/java/com/baomidou/mybatisplus/core/conditions/LambdaUpdateWrapperTest.java
diff --git a/...ore/src/test/java/com/baomidou/mybatisplus/core/conditions/UpdateWrapperIncrDecrTest.java b/...ore/src/test/java/com/baomidou/mybatisplus/core/conditions/UpdateWrapperIncrDecrTest.java
@@ -0,0 +1,67 @@
+package com.baomidou.mybatisplus.core.conditions;
+
+import com.baomidou.mybatisplus.core.MybatisConfiguration;
+import com.baomidou.mybatisplus.core.conditions.update.LambdaUpdateWrapper;
+import com.baomidou.mybatisplus.core.conditions.update.Update;
+import com.baomidou.mybatisplus.core.conditions.update.UpdateWrapper;
+import com.baomidou.mybatisplus.core.metadata.TableInfo;
+import com.baomidou.mybatisplus.core.metadata.TableInfoHelper;
+import com.baomidou.mybatisplus.test.User;
+import org.apache.ibatis.builder.MapperBuilderAssistant;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.Test;
+
+import java.math.BigDecimal;
+
+/**
+ * @author miemie
+ * @since 2021-01-27
+ */
+class UpdateWrapperIncrDecrTest extends BaseWrapperTest {
+
+    @BeforeAll
+    static void initUser() {
+        TableInfo tableInfo = TableInfoHelper.initTableInfo(new MapperBuilderAssistant(new MybatisConfiguration(), ""), User.class);
+        Assertions.assertEquals("sys_user", tableInfo.getTableName());
+    }
+
+    @Test
+    void testIncrByAndDecrBy() {
+        assertEquals(new UpdateWrapper<User>()
+                .setIncrBy("role_id", 1).setDecrBy("username", 1),
+            "role_id=role_id + 1,username=username - 1");
+
+        assertEquals(new LambdaUpdateWrapper<User>()
+                .setIncrBy(User::getRoleId, 1).setDecrBy(User::getName, 1),
+            "role_id=role_id + 1,username=username - 1");
+    }
+
+    @Test
+    void testIncrByAndDecrByBigDecimal() {
+        assertEquals(new LambdaUpdateWrapper<User>()
+                .setIncrBy(User::getRoleId, new BigDecimal("1"))
+                .setIncrBy(User::getRoleId, new BigDecimal(1))
+                .setIncrBy(User::getRoleId, new BigDecimal(1.0000))
+                .setIncrBy(User::getRoleId, new BigDecimal("1.0000"))
+                .setIncrBy(User::getRoleId, new BigDecimal("0.01"))
+                .setIncrBy(User::getRoleId, new BigDecimal("2340")),
+            "role_id=role_id + 1,role_id=role_id + 1,role_id=role_id + 1," +
+                "role_id=role_id + 1.0000,role_id=role_id + 0.01,role_id=role_id + 2340");
+
+        assertEquals(new LambdaUpdateWrapper<User>()
+                .setDecrBy(User::getRoleId, new BigDecimal("1"))
+                .setDecrBy(User::getRoleId, new BigDecimal(1))
+                .setDecrBy(User::getRoleId, new BigDecimal(1.0000))
+                .setDecrBy(User::getRoleId, new BigDecimal("1.0000"))
+                .setDecrBy(User::getRoleId, new BigDecimal("0.01"))
+                .setDecrBy(User::getRoleId, new BigDecimal("2340")),
+            "role_id=role_id - 1,role_id=role_id - 1,role_id=role_id - 1," +
+                "role_id=role_id - 1.0000,role_id=role_id - 0.01,role_id=role_id - 2340");
+    }
+
+
+    private void assertEquals(Update<?, ?> update, String sql) {
+        Assertions.assertEquals(sql, update.getSqlSet());
+    }
+}
diff --git a/...us-extension/src/main/kotlin/com/baomidou/mybatisplus/extension/kotlin/KtUpdateWrapper.kt b/...us-extension/src/main/kotlin/com/baomidou/mybatisplus/extension/kotlin/KtUpdateWrapper.kt
@@ -83,17 +83,17 @@ open class KtUpdateWrapper<T : Any> : AbstractKtWrapper<T, KtUpdateWrapper<T>>,
         }
     }
 
-    override fun setDecrBy(condition: Boolean, column: KProperty1<in T, *>, `val`: Number): KtUpdateWrapper<T> {
+    override fun setIncrBy(condition: Boolean, column: KProperty1<in T, *>, `val`: Number): KtUpdateWrapper<T> {
         return maybeDo(condition) {
             val realColumn = columnToString(column)
-            sqlSet.add(realColumn + Constants.EQUALS + realColumn + Constants.SPACE + Constants.PLUS + Constants.SPACE + (if (`val` is BigDecimal) `val`.toPlainString() else `val`))
+            sqlSet.add(String.format("%s=%s + %s", realColumn, realColumn, if (`val` is BigDecimal) `val`.toPlainString() else `val`))
         }
     }
 
-    override fun setIncrBy(condition: Boolean, column: KProperty1<in T, *>, `val`: Number): KtUpdateWrapper<T> {
+    override fun setDecrBy(condition: Boolean, column: KProperty1<in T, *>, `val`: Number): KtUpdateWrapper<T> {
         return maybeDo(condition) {
             val realColumn = columnToString(column)
-            sqlSet.add(realColumn + Constants.EQUALS + realColumn + Constants.SPACE + Constants.DASH + Constants.SPACE + (if (`val` is BigDecimal) `val`.toPlainString() else `val`))
+            sqlSet.add(String.format("%s=%s - %s", realColumn, realColumn, if (`val` is BigDecimal) `val`.toPlainString() else `val`));
         }
     }