Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tsp report #536

Open
wants to merge 98 commits into
base: develop
Choose a base branch
from
Open

Tsp report #536

wants to merge 98 commits into from

Conversation

pchtsp
Copy link
Collaborator

@pchtsp pchtsp commented May 17, 2024

A draft example of a report using quarto + cornflow structure. I've edited (probably incorrectly) de requirements.txt of DAGs.

This PR should help standardize the way reports are stored and handled in cornflow.

@ggsdc ggsdc changed the base branch from master to development May 17, 2024 13:34
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 71.97987% with 167 lines in your changes missing coverage. Please review.

Project coverage is 74.78%. Comparing base (3c2a88b) to head (6845f53).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #536      +/-   ##
===========================================
- Coverage    75.24%   74.78%   -0.47%     
===========================================
  Files          258      261       +3     
  Lines        14428    14933     +505     
  Branches      2932     3027      +95     
===========================================
+ Hits         10856    11167     +311     
- Misses        3105     3293     +188     
- Partials       467      473       +6     
Flag Coverage Δ
client-tests 72.43% <58.76%> (-5.39%) ⬇️
dags-tests 77.42% <63.30%> (-0.23%) ⬇️
server-tests 78.27% <86.31%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
server 78.29% <86.31%> (+0.46%) ⬆️
client 72.43% <58.76%> (-5.39%) ⬇️
dags 77.42% <63.30%> (-0.23%) ⬇️

@ggsdc ggsdc changed the base branch from development to master June 27, 2024 14:41
@ggsdc ggsdc changed the base branch from master to development June 27, 2024 14:41
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so the main issue is that this new version of activate dags seems like it does not work properly, or at least I am not able to make it work (for now) on my machine

@ggsdc
Copy link
Member

ggsdc commented Jun 28, 2024

So cornflow-dags and cornflow-server tests are passing. We still have an issue with the integration tests for cornflow-client, but this issue is a known one. Will try to improve it so that test pass at once and we do not have to manually rerun them for them to pass

@ggsdc
Copy link
Member

ggsdc commented Jul 26, 2024

Coverage report is now fixed. It seems that is still far from what the minimum coverage should be. I will keep reviewing it just in case we can improve it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants