Feature/test deployed dags #481
Conversation
…with the default values defined.
Codecov Report
@@ Coverage Diff @@
## development #481 +/- ##
===============================================
+ Coverage 78.77% 78.94% +0.17%
===============================================
Files 234 263 +29
Lines 12784 14807 +2023
===============================================
+ Hits 10070 11689 +1619
- Misses 2714 3118 +404
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 79 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| notify = getattr(app, "notify", True) | ||
| if not notify: |
There was a problem hiding this comment.
This change @AlejandraGalan done over your code is to make sure that this change is compatible with older versions cornflow-client just in case
|
|
||
| instance_id = response["id"] | ||
|
|
||
| config = {"timeLimit": 60, "msg": True, "seconds": 60} |
There was a problem hiding this comment.
@marioncottard I am getting a lot of weird behaviours with this part of timeLimit and seconds. Could you start preparing a PR that modifies all example DAGs to use the translation dictionaries that we had created?
| new_config, config_errors = json_schema_extend_and_validate_as_string( | ||
| config_schema, kwargs["config"] | ||
| ) |
There was a problem hiding this comment.
@marioncottard This is the new validation that adds the default values (if needed) before validating the schema
Deleted unreacheble code on executions
Added a DAG that automatically runs all examples uploaded (one per dag) and runs them against cornflow to check that everything works properly.
Some small changes for DAGs to run properly.
Finished SendGrid integration in Airflow.
Closes #475