Apply offset only if not null

[marioncottard]

No description provided.

[ggsdc]

Why did you close it?

[marioncottard]

Because I can't figure out why this breaks the tests and I can do it another way

[ggsdc]

The failing test are not your fault, I have been fighting with them the past days. If you run them again it should work eventually

…

On Fri, Oct 6, 2023, 13:43 marioncottard ***@***.***> wrote: Because I can't figure out why this breaks the tests and I can do it another way — Reply to this email directly, view it on GitHub <#480 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AF4DGHFUUUVL6JAL26JI533X57VEHAVCNFSM6AAAAAA5UKU676VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJQGUYDANBYHE> . You are receiving this because you commented.Message ID: ***@***.***>

[marioncottard]

Okay, I'll try then

[ggsdc]

Could you solve the conflicts (due to me commenting a big part of the code to check if the test now pass)

[codecov]

Codecov Report

Attention: Patch coverage is 12.00000% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 78.82%. Comparing base (31d00cc) to head (b633d60).

Files	Patch %	Lines
...flow-server/cornflow/cli/tools/schema_generator.py	6.66%	42 Missing ⚠️
cornflow-server/cornflow/models/meta_models.py	60.00%	2 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           development     #480      +/-   ##
===============================================
- Coverage        79.04%   78.82%   -0.23%     
===============================================
  Files              263      263              
  Lines            14856    14903      +47     
===============================================
+ Hits             11743    11747       +4     
- Misses            3113     3156      +43     

Flag	Coverage Δ
server-tests	82.56% <12.00%> (-0.62%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[marioncottard]

I've left commented the tests that you commented, because even though they passed on local, they wouldn't pass here