Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): add ci submodule #68

Merged
merged 7 commits into from
Oct 27, 2023
Merged

feat(ci): add ci submodule #68

merged 7 commits into from
Oct 27, 2023

Conversation

danielRep
Copy link
Member

@danielRep danielRep commented Jul 28, 2023

PR Description

This PR adds the bao-ci as submodule of the bao-docs repo. This is beneficial to allow the user to use the docker environment locally.

Type of change

  • feat: introduces a new functionality
    • Logical unit: ci

Checklist:

  • The changes follows the documentation guidelines described in here.
  • The changes generate no new warnings when building the project. If so, I have justified above.
  • I have run the CI checkers before submitting the PR to avoid unnecessary runs of the workflow.

@josecm josecm self-assigned this Sep 15, 2023
Copy link
Member

@josecm josecm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any PR in https://github.com/bao-project/bao-ci that adds the doc8 check to ci.mk

.github/workflows/base-ci.yml Outdated Show resolved Hide resolved
.github/workflows/base-ci.yml Outdated Show resolved Hide resolved
.gitmodules Outdated Show resolved Hide resolved
@danielRep
Copy link
Member Author

danielRep commented Sep 15, 2023

Is there any PR in https://github.com/bao-project/bao-ci that adds the doc8 check to ci.mk

I totally forgot to create the PR @josecm. Here it is: bao-project/bao-ci#50

@danielRep danielRep force-pushed the feat/add_ci_submodule branch 4 times, most recently from ff30489 to e1f3583 Compare September 15, 2023 16:12
@danielRep danielRep force-pushed the feat/add_ci_submodule branch 2 times, most recently from 25dbdd7 to 2ffbe14 Compare September 15, 2023 16:43
Signed-off-by: Daniel Oliveira <[email protected]>
.github/workflows/base-ci.yml Show resolved Hide resolved
@josecm josecm merged commit 5a84a6a into main Oct 27, 2023
4 checks passed
@danielRep danielRep deleted the feat/add_ci_submodule branch December 7, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants