check stacked time system size to make sure it's square (#64)

bankofcanada · Nov 5, 2024 · d637c49 · d637c49
1 parent 8446b04
commit d637c49
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -20,7 +20,7 @@ jobs:
 
     strategy: 
       matrix:
-        julia-version: ["1.7", "1.8", "1.9"]
+        julia-version: ["1.9", "lts", "1"]
         julia-arch: [x64]
         os: [ubuntu-latest, windows-latest, macOS-latest]
 

diff --git a/src/stackedtime/solverdata.jl b/src/stackedtime/solverdata.jl
@@ -236,7 +236,9 @@ function update_plan!(sd::StackedTimeSolverData, model::Model, plan::Plan; chang
     if changed
         @. sd.solve_mask = !(sd.fc_mask | sd.exog_mask)
         @assert !any(sd.exog_mask .& sd.fc_mask)
-        @assert sum(sd.solve_mask) == size(sd.J, 1)
+        if sum(sd.solve_mask) != size(sd.J, 1)
+            throw(ArgumentError("Mismatch in the numbers of equations ($(size(sd.J, 1))) and unknowns ($(sum(sd.solve_mask))).\nCheck the model definition and the simulation plan."))
+        end
         sm_index = cumsum(sd.solve_mask)
 
         # Update the Jacobian correction matrix, if exogenous plan changed