Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitenberg: Import webpack auto reload extension #1

Merged
merged 1 commit into from
May 26, 2023

Conversation

bangank36
Copy link
Owner

Copy link
Owner Author

@bangank36 bangank36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge, but there are some notes:

  • Figure the way of changing userDataDir, it opens new profile by default and adding false lead to create a new folder
  • Make startingUrl an option somewhere

@@ -45,6 +48,10 @@ const config = {
// new webpack.ProvidePlugin( {
// process: 'process/browser',
// } ),
new RunChromeExtension({
extensionPath: path.resolve( __dirname ),
startingUrl: 'https://github.com/bangank36/spriral-learning/issues/17'
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the default URL to navigate when developing

@bangank36 bangank36 self-assigned this May 26, 2023
@bangank36 bangank36 added the enhancement New feature or request label May 26, 2023
@bangank36 bangank36 merged commit e5b0971 into trunk May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant