Remove minimum constraint on opensearch hosts

Signed-off-by: Bandini Bhopi <[email protected]>

config/opensearch_dashboards.yml

@@ -267,4 +267,3 @@
 
 # Set the value of this setting to true to enable plugin augmentation on Dashboard
 # vis_augmenter.pluginAugmentationEnabled: true
-

src/core/server/opensearch/opensearch_config.ts

@@ -53,7 +53,7 @@ export const configSchema = schema.object({
     defaultValue: false,
   }),
   sniffOnConnectionFault: schema.boolean({ defaultValue: false }),
-  hosts: schema.oneOf([hostURISchema, schema.arrayOf(hostURISchema, { minSize: 1 })], {
+  hosts: schema.oneOf([hostURISchema, schema.arrayOf(hostURISchema)], {
     defaultValue: 'http://localhost:9200',
   }),
   username: schema.maybe(

src/core/server/saved_objects/saved_objects_service.ts

@@ -464,15 +464,6 @@ export class SavedObjectsService
         'Waiting until all OpenSearch nodes are compatible with OpenSearch Dashboards before starting saved objects migrations...'
       );
 
-      // TODO: Move to Status Service https://github.com/elastic/kibana/issues/41983
-      this.setupDeps!.opensearch.opensearchNodesCompatibility$.subscribe(
-        ({ isCompatible, message }) => {
-          if (!isCompatible && message) {
-            this.logger.error(message);
-          }
-        }
-      );
-
       await this.setupDeps!.opensearch.opensearchNodesCompatibility$.pipe(
         filter((nodes) => nodes.isCompatible),
         take(1)

src/core/server/status/status_service.ts

@@ -48,6 +48,9 @@ import { ServiceStatus, CoreStatus, InternalStatusServiceSetup } from './types';
 import { getSummaryStatus } from './get_summary_status';
 import { PluginsStatusService } from './plugins_status';
 
+import { OpenSearchConfig } from '../../server/opensearch';
+import { OpenSearchConfigType } from '../opensearch/opensearch_config';
+
 interface SetupDeps {
   opensearch: Pick<InternalOpenSearchServiceSetup, 'status$'>;
   environment: InternalEnvironmentServiceSetup;
@@ -60,13 +63,17 @@ interface SetupDeps {
 export class StatusService implements CoreService<InternalStatusServiceSetup> {
   private readonly logger: Logger;
   private readonly config$: Observable<StatusConfigType>;
+  private readonly openSearchConfig$: Observable<OpenSearchConfig>;
 
   private pluginsStatus?: PluginsStatusService;
   private overallSubscription?: Subscription;
 
   constructor(private readonly coreContext: CoreContext) {
     this.logger = coreContext.logger.get('status');
     this.config$ = coreContext.configService.atPath<StatusConfigType>(config.path);
+    this.openSearchConfig$ = coreContext.configService
+      .atPath<OpenSearchConfigType>('opensearch')
+      .pipe(map((rawConfig) => new OpenSearchConfig(rawConfig)));
   }
 
   public async setup({
@@ -78,7 +85,9 @@ export class StatusService implements CoreService<InternalStatusServiceSetup> {
     environment,
   }: SetupDeps) {
     const statusConfig = await this.config$.pipe(take(1)).toPromise();
-    const core$ = this.setupCoreStatus({ opensearch, savedObjects });
+    const openSearchConfig = await this.openSearchConfig$.pipe(take(1)).toPromise();
+    const isOpenSearchEnabled = openSearchConfig.hosts.length > 0;
+    const core$ = this.setupCoreStatus({ opensearch, savedObjects }, isOpenSearchEnabled);
     this.pluginsStatus = new PluginsStatusService({ core$, pluginDependencies });
 
     const overall$: Observable<ServiceStatus> = combineLatest([
@@ -140,15 +149,23 @@ export class StatusService implements CoreService<InternalStatusServiceSetup> {
     }
   }
 
-  private setupCoreStatus({
-    opensearch,
-    savedObjects,
-  }: Pick<SetupDeps, 'opensearch' | 'savedObjects'>): Observable<CoreStatus> {
+  private setupCoreStatus(
+    { opensearch, savedObjects }: Pick<SetupDeps, 'opensearch' | 'savedObjects'>,
+    isOpenSearchEnabled: boolean = true
+  ): Observable<CoreStatus> {
     return combineLatest([opensearch.status$, savedObjects.status$]).pipe(
-      map(([opensearchStatus, savedObjectsStatus]) => ({
-        opensearch: opensearchStatus,
-        savedObjects: savedObjectsStatus,
-      })),
+      map(([opensearchStatus, savedObjectsStatus]) => {
+        if (isOpenSearchEnabled) {
+          return {
+            opensearch: opensearchStatus,
+            savedObjects: savedObjectsStatus,
+          };
+        } else {
+          return {
+            savedObjects: savedObjectsStatus,
+          };
+        }
+      }),
       distinctUntilChanged<CoreStatus>(isDeepStrictEqual),
       shareReplay(1)
     );

src/core/server/status/types.ts

@@ -134,7 +134,7 @@ export type ServiceStatusLevel = typeof ServiceStatusLevels[keyof typeof Service
  * @public
  */
 export interface CoreStatus {
-  opensearch: ServiceStatus;
+  opensearch?: ServiceStatus;
   savedObjects: ServiceStatus;
 }