Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

carbon vortex - handle edge case #153

Merged
merged 3 commits into from
Jul 25, 2024
Merged

carbon vortex - handle edge case #153

merged 3 commits into from
Jul 25, 2024

Conversation

ivanzhelyazkov
Copy link
Collaborator

  • Handle edge case when user sends unnecessary native tokens if the token traded is not native
  • Add tests

@ivanzhelyazkov ivanzhelyazkov requested a review from barakman July 18, 2024 10:19
@ivanzhelyazkov ivanzhelyazkov requested a review from barakman July 18, 2024 11:54
@ivanzhelyazkov ivanzhelyazkov merged commit ef6f3b6 into dev Jul 25, 2024
3 checks passed
@ivanzhelyazkov ivanzhelyazkov deleted the carbon-vortex-2.0 branch July 25, 2024 12:50
0xMotto pushed a commit to Velocimeter/carbon-contracts that referenced this pull request Oct 11, 2024
@ivanzhelyazkov
Merge pull request bancorprotocol#153 from bancorprotocol/carbon-vort…
33df4a9 
…ex-2.0

carbon vortex - handle edge case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbeder lbeder lbeder approved these changes

@barakman barakman barakman approved these changes

@yudilevi yudilevi yudilevi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ivanzhelyazkov @yudilevi @lbeder @barakman