Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2201.8.x] Update sql version to 1.12.3 #740

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

MohamedSabthar
Copy link
Member

Purpose

Related to: #739

Examples

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

@MohamedSabthar MohamedSabthar changed the title Update minor version [2201.8.x] Update minor version Oct 13, 2024
@daneshk
Copy link
Member

daneshk commented Oct 13, 2024

@MohamedSabthar, we can't do a minor bump with 2201.8.x branch now. why do we need to bump a minor release?

@MohamedSabthar
Copy link
Member Author

@MohamedSabthar, we can't do a minor bump with 2201.8.x branch now. why do we need to bump a minor release?

In the previous version, users could call the close method on ProcedureCallResult before obtaining the result from the output parameter. With this fix, it is expected that ProcedureCallResult should be closed only after calling the get method on the output parameter; otherwise, calling get will result in an error. This change can be considered a breaking change. However, following an offline discussion with @daneshk, we will release this fix as a patch version, as calling close on ProcedureCallResult is not recommended in any of our specifications and it is generally not considered best practice to close it while consuming the result.

@MohamedSabthar MohamedSabthar changed the title [2201.8.x] Update minor version [2201.8.x] Update sql version to 1.12.3 Oct 14, 2024
Copy link

sonarcloud bot commented Oct 14, 2024

@MohamedSabthar MohamedSabthar merged commit bd5de6e into ballerina-platform:2201.8.x Oct 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants