-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keccak_256 hashing #578
Conversation
Keccak 256
Keccak 256
fix typo in readme
native/src/main/java/io/ballerina/stdlib/crypto/nativeimpl/Hash.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/stdlib/crypto/nativeimpl/Hash.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/stdlib/crypto/CryptoUtils.java
Outdated
Show resolved
Hide resolved
@thil4n let's update the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine, let's update the spec and the changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
native/src/main/java/io/ballerina/stdlib/crypto/CryptoUtils.java
Outdated
Show resolved
Hide resolved
@thil4n let's resolve the conflicts |
Okay, will do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
Purpose
This PR introduces implementation for keccak256 hashing in Ballerina Crypto Module. Keccak-256 is widely used in blockchain related technologies and currently Ballerina crypto module does not provide the Keccak-256 algorithm.
Examples
string dataString = "Hello Ballerina";
byte[] data = dataString.toBytes();
byte[] hash = crypto:hashKeccak256(data);
Checklist