Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler crashes for raw template with interpolations when used as a default value of a parameter #43799

Merged
merged 5 commits into from
Feb 21, 2025

Conversation

chiranSachintha
Copy link
Member

Purpose

$title.

Fixes #43775

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@chiranSachintha chiranSachintha added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Feb 6, 2025
gimantha
gimantha previously approved these changes Feb 6, 2025
@chiranSachintha chiranSachintha dismissed stale reviews from MaryamZi and gimantha via 566e8cb February 18, 2025 06:10
@keizer619 keizer619 added this to the 2201.12.0 milestone Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.39%. Comparing base (f6d2a94) to head (bb68a60).
Report is 8 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #43799      +/-   ##
============================================
- Coverage     77.40%   77.39%   -0.01%     
+ Complexity    58698    58693       -5     
============================================
  Files          3451     3451              
  Lines        219450   219450              
  Branches      29020    29020              
============================================
- Hits         169866   169847      -19     
- Misses        40128    40147      +19     
  Partials       9456     9456              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tharindu-nw tharindu-nw merged commit b3de437 into ballerina-platform:master Feb 21, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
5 participants