Skip to content
This repository was archived by the owner on Oct 24, 2024. It is now read-only.

Fix build failure #309

Merged
merged 5 commits into from
Oct 13, 2022
Merged

Fix build failure #309

merged 5 commits into from
Oct 13, 2022

Conversation

aashikam
Copy link
Contributor

@aashikam aashikam commented Oct 12, 2022

Purpose

fixes: ballerina-platform/ballerina-library#3496

Description

Build Failure

Note: NATS streaming server, java NATS streaming client, NATS streaming server docker are all deprecated and will be dead by June next year.

The TLS tests were failing. Tried the following.

  • Updating crypto dependency and certificates - didn't work
  • Disabled tests - reduced cod cov to 75%
  • Changed docker image used by TLS server from latest to something that worked before (0.24.6) - this worked

Note: Should add a deprecation notice to ballerinax/stan as well. Issue.

Trivy Failure
Java dependency is the last version they have released and they haven't released anything after 2.2.3. https://github.com/nats-io/stan.java/releases. Therefore can't upgrade this. Not sure what to do about this. Vulnerability warnings are shown here too https://mvnrepository.com/artifact/io.nats/java-nats-streaming/2.2.3. Trivy might fail indefinitely.

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec

@aashikam aashikam changed the title Update crypto dependency Disable TLS test cases Oct 12, 2022
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 80.84% // Head: 80.84% // No change to project coverage 👍

Coverage data is based on head (7355fb8) compared to base (75f79bd).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #309   +/-   ##
=========================================
  Coverage     80.84%   80.84%           
  Complexity      107      107           
=========================================
  Files            26       26           
  Lines           689      689           
  Branches         71       71           
=========================================
  Hits            557      557           
  Misses           92       92           
  Partials         40       40           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aashikam aashikam changed the title Disable TLS test cases Fix build failure Oct 12, 2022
@aashikam aashikam marked this pull request as ready for review October 12, 2022 14:51
@aashikam aashikam requested a review from chamil321 October 12, 2022 14:54
@dilanSachi
Copy link
Contributor

Trivy failure is due to protobuf version right? Not java-nats-streaming-2.2.3

@aashikam
Copy link
Contributor Author

aashikam commented Oct 12, 2022

Trivy failure is due to protobuf version right? Not java-nats-streaming-2.2.3

it is a dependency of java-nats-streaming-2.2.3 @dilanSachi

Screenshot 2022-10-12 at 20 47 41

@dilanSachi
Copy link
Contributor

That version is 3.9.1 right? But the trivy scan fails with 3.20.1. Cant we update it into 3.20.3 in Ballerina.toml

@aashikam
Copy link
Contributor Author

aashikam commented Oct 12, 2022

That version is 3.9.1 right? But the trivy scan fails with 3.20.1. Cant we update it into 3.20.3 in Ballerina.toml

Updated in 7355fb8

@aashikam aashikam merged commit 5a59fbb into ballerina-attic:main Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix STAN daily build fail
3 participants