add flash from file endpoint #93
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-type: patch Signed-off-by: Ryan Cooke <[email protected]>
Change-type: patch Signed-off-by: Ryan Cooke <[email protected]>
Change-type: patch Signed-off-by: Ryan Cooke <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+398
to
+426
| async (req: express.Request, res: express.Response) => { | ||
| res.writeHead(202, { | ||
| 'Content-Type': 'text/event-stream', | ||
| Connection: 'keep-alive', | ||
| }); | ||
|
|
||
| const timer = setInterval(() => { | ||
| res.write('status: pending'); | ||
| }, 5000); | ||
|
|
||
|
|
||
| try { | ||
| let FILENAME = req.body.filename; | ||
| if(FILENAME.includes(`.gz`)){ | ||
| console.log(`Unzipping file`) | ||
| console.log(await execSync(`gunzip -f ${FILENAME}`)) | ||
| FILENAME = FILENAME.replace(/\.gz$/, ''); | ||
| } | ||
| console.log(`Attempting to flash with file: ${FILENAME}...`); | ||
| await worker.flash(FILENAME); | ||
| clearInterval(timer); | ||
| res.end() | ||
| } catch (e) { | ||
| //TODO: respdond with error instead of just doing nothing | ||
| console.log(e); | ||
| clearInterval(timer); | ||
| res.end() | ||
| } | ||
| } |
Check failure
Code scanning / CodeQL
Missing rate limiting High
| let FILENAME = req.body.filename; | ||
| if(FILENAME.includes(`.gz`)){ | ||
| console.log(`Unzipping file`) | ||
| console.log(await execSync(`gunzip -f ${FILENAME}`)) |
Check failure
Code scanning / CodeQL
Uncontrolled command line Critical
lib/index.ts
Outdated
| @@ -356,7 +362,7 @@ async function setup( | |||
|
|
|||
| const timer = setInterval(() => { | |||
| res.write('status: pending'); | |||
| }, httpServer.keepAliveTimeout); | |||
| }, 5000); | |||
There was a problem hiding this comment.
Thanks for defining this. So helpful
|
|
||
|
|
||
| try { | ||
| let FILENAME = req.body.filename; |
There was a problem hiding this comment.
Suggested change
| let FILENAME = req.body.filename; | |
| const FILENAME = req.body.filename; |
| if(FILENAME.includes(`.gz`)){ | ||
| console.log(`Unzipping file`) | ||
| console.log(await execSync(`gunzip -f ${FILENAME}`)) | ||
| FILENAME = FILENAME.replace(/\.gz$/, ''); |
There was a problem hiding this comment.
Suggested change
| FILENAME = FILENAME.replace(/\.gz$/, ''); |
| FILENAME = FILENAME.replace(/\.gz$/, ''); | ||
| } | ||
| console.log(`Attempting to flash with file: ${FILENAME}...`); | ||
| await worker.flash(FILENAME); |
There was a problem hiding this comment.
Suggested change
| await worker.flash(FILENAME); | |
| await worker.flash(FILENAME.replace(/\.gz$/, '')); |
Are we deleting the zipped file after the unzipping. Just making sure the clean up happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows to flash from a file on the worker without streaming it over http first