address image sending timeouts #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
Change-type: patch Signed-off-by: Ryan Cooke <[email protected]>
Change-type: patch Signed-off-by: Ryan Cooke <[email protected]>
rcooke-warwick
force-pushed
the
ryan/timeout-tests
branch
from
4c1cdcc to
42d5168
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change to be paired with balena-os/leviathan#1072 to try to reduce the risk of connection drops while streaming the OS images to the worker. For larger images, especially when preloaded, the connection is prone to timing out. These PR's attempt to remove the http request and server timeouts.
The seperate heartbeat timeout that we have will timeout the test run if something goes wrong.
Change-type: patch