Fixes to takeover upgrade script in preparation for release #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ensure work dir cleaned up * Update for revised takeover binary options * Use latest release Change-type: patch Signed-off-by: Ken Bannister <[email protected]>
kb2ma
commented
Dec 5, 2024
| @@ -186,7 +186,7 @@ function cleanup_work_dir() { | |||
| # Ensure takover path is not just '/' because deletion command is | |||
| if [[ -n "${work_dir}" && "${#work_dir}" -gt 3 ]]; then | |||
| if [[ -d "${work_dir}" ]]; then | |||
| rm -rf "${work_dir:?}/*" | |||
| rm -rf "${work_dir:?}/"* | |||
There was a problem hiding this comment.
Need the globbing character outside the parentheses to work.
kb2ma
commented
Dec 5, 2024
| @@ -300,6 +300,11 @@ starttime=$(date +%s) | |||
| if [ -d "/mnt/data/resinhup" ] && [ ! -e "/mnt/data/balenahup" ]; then | |||
| ln -s "/mnt/data/resinhup" "/mnt/data/balenahup" | |||
| fi | |||
| # Directory for downloaded/temporary files. MUST be in data partition since stores | |||
There was a problem hiding this comment.
Moved up higher in the script so always defined for users.
kb2ma
commented
Dec 5, 2024
| # data partition since stores sizable downloaded OS image. Conserves memory for | ||
| # takeover binary. | ||
| work_dir="/mnt/data/takeover" | ||
| # Ensure any already existing working directory is empty; takeover binary does |
There was a problem hiding this comment.
Just moved closer to where directory is created for clarity.
alexgg
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: patch